OCPBUGS-55359: install/0000_00_cluster-version-operator_01_admingate_configmap: Add ack-4.18-kube-1.32-api-removals-in-4.19 #1181

wking · 2025-04-25T01:25:33Z

Like 898b74c (#1085) and similar.

…ack-4.18-kube-1.32-api-removals-in-4.19 Like 898b74c (Add admin-gate for OCP 4.17, 2024-09-06, openshift#1085) and similar.

openshift-ci-robot · 2025-04-25T01:25:39Z

@wking: This pull request references Jira Issue OCPBUGS-55359, which is invalid:

expected the bug to target the "4.18.z" version, but no target version was set
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-55359 to depend on a bug targeting a version in 4.19.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Like 898b74c (#1085) and similar.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

wking · 2025-04-25T01:28:54Z

/jira refresh

openshift-ci-robot · 2025-04-25T01:28:57Z

@wking: This pull request references Jira Issue OCPBUGS-55359, which is invalid:

expected Jira Issue OCPBUGS-55359 to depend on a bug targeting a version in 4.19.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

wking · 2025-04-25T01:30:07Z

expected Jira Issue OCPBUGS-55359 to depend on a bug targeting a version in 4.19.0...

This is expected for this 4.18-to-4.19 guard (no 4.19 code needed, by the time you're running 4.19 code in your cluster, you're already past the point we want to guard). I'll manually set jira/valid-bug to waive this portion of the usual backport process.

wking · 2025-04-25T01:30:31Z

/label backport-risk-assessed

wking · 2025-04-25T04:50:37Z

e2e-agnostic-operator had infra-capacity issues (control-plane-machine-set Available is False with UnavailableReplicas: Missing 1 available replica) and e2e-hypershift-conformance had the low-detail:

: [sig-arch][Late] operators should have watch channel requests	0s
{Expected at least one watch request count to be present  }

Neither seems related to my change.

/retest-required

dis016 · 2025-04-25T11:41:21Z

install/0000_00_cluster-version-operator_01_admingate_configmap.yaml

    include.release.openshift.io/self-managed-high-availability: "true"
+data:
+  ack-4.18-kube-1.32-api-removals-in-4.19: |-
+      Kubernetes 1.32 and therefore OpenShift 4.19 remove several APIs which require admin consideration. Please see the knowledge article https://access.redhat.com/articles/7112216 for details and instructions.


Hi @wking as per the doc link https://access.redhat.com/articles/7112216,

Per the [Kubernetes documentation](https://access.redhat.com/bounce/?externalURL=https%3A%2F%2Fkubernetes.io%2Fdocs%2Freference%2Fusing-api%2Fdeprecation-guide%2F%23v1-29), Kubernetes 1.32 removed several deprecated APIs. OpenShift Container Platform 4.19 plans to use Kubernetes 1.32. Unlike past releases of OpenShift Container Platform that introduced Kubernetes API removals, OpenShift Container Platform 4.19 does not require an administrator acknowledgment before upgrading to it.

bit confused over the statements, and i dont see in doc that the acknowledgement is required.

Nice catch! It's @bergerhoffer 's KCS, and she's said she can have it updated and published by Wednesday the 30th, when the next 4.18.z that might consume this will be built. So I think we can merge as it stands, and have the KCS updated to call out the need for an ack by the time customers might be running clusters with the gate.

KCS is updated to reflect that there is actually going to be an admin-ack this time. Once this PR merges and we know what z-stream it'll be in, I'll update the KCS with that value and publish.

hongkailiu · 2025-04-25T20:24:02Z

/lgtm

openshift-ci · 2025-04-25T20:24:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dis016 · 2025-04-30T07:29:38Z

we will be doing post-merge testing so approving for merging
/no-qe

petr-muller · 2025-05-02T17:00:33Z

@dis016 needs to be a /label command

/label no-qe

dis016 · 2025-05-03T15:23:53Z

Thanks @petr-muller
/label no-qe

jiajliu · 2025-05-06T00:12:27Z

/label cherry-pick-approved

openshift-ci-robot · 2025-05-06T00:42:08Z

/retest-required

Remaining retests: 0 against base HEAD 3646a10 and 2 for PR HEAD d9b741a in total

openshift-ci · 2025-05-06T02:33:22Z

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-05-06T02:37:44Z

@wking: Jira Issue OCPBUGS-55359: All pull requests linked via external trackers have merged:

openshift/cluster-version-operator#1181

Jira Issue OCPBUGS-55359 has been moved to the MODIFIED state.

Details

In response to this:

Like 898b74c (#1085) and similar.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2025-05-06T05:22:43Z

[ART PR BUILD NOTIFIER]

Distgit: cluster-version-operator
This PR has been included in build cluster-version-operator-container-v4.18.0-202505060434.p0.g94c0e70.assembly.stream.el9.
All builds following this will include this PR.

openshift-merge-robot · 2025-05-06T23:19:01Z

Fix included in accepted release 4.18.0-0.nightly-2025-05-06-153745

install/0000_00_cluster-version-operator_01_admingate_configmap: Add …

d9b741a

…ack-4.18-kube-1.32-api-removals-in-4.19 Like 898b74c (Add admin-gate for OCP 4.17, 2024-09-06, openshift#1085) and similar.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 25, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2025

wking added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 25, 2025

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 25, 2025

dis016 reviewed Apr 25, 2025

View reviewed changes

openshift-ci bot assigned hongkailiu Apr 25, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2025

openshift-ci bot added the no-qe Allows PRs to merge without qe-approved label label May 2, 2025

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 6, 2025

openshift-merge-bot bot merged commit 94c0e70 into openshift:release-4.18 May 6, 2025
12 checks passed

wking deleted the ack-4.18-kube-1.32-api-removals-in-4.19 branch May 6, 2025 03:59

OCPBUGS-55359: install/0000_00_cluster-version-operator_01_admingate_configmap: Add ack-4.18-kube-1.32-api-removals-in-4.19 #1181

OCPBUGS-55359: install/0000_00_cluster-version-operator_01_admingate_configmap: Add ack-4.18-kube-1.32-api-removals-in-4.19 #1181

Uh oh!

Conversation

wking commented Apr 25, 2025

Uh oh!

openshift-ci-robot commented Apr 25, 2025

Uh oh!

wking commented Apr 25, 2025

Uh oh!

openshift-ci-robot commented Apr 25, 2025

Uh oh!

wking commented Apr 25, 2025

Uh oh!

wking commented Apr 25, 2025

Uh oh!

wking commented Apr 25, 2025

Uh oh!

dis016 Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

wking Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

bergerhoffer Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

hongkailiu commented Apr 25, 2025

Uh oh!

openshift-ci bot commented Apr 25, 2025

Uh oh!

dis016 commented Apr 30, 2025

Uh oh!

petr-muller commented May 2, 2025

Uh oh!

dis016 commented May 3, 2025

Uh oh!

jiajliu commented May 6, 2025

Uh oh!

openshift-ci-robot commented May 6, 2025

Uh oh!

openshift-ci bot commented May 6, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented May 6, 2025

Uh oh!

openshift-bot commented May 6, 2025

Uh oh!

openshift-merge-robot commented May 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants